refactor(ED25519/keyloader): Change to load from raw bytes.#16
Closed
tinymahua wants to merge 9 commits intopyauth:mainfrom
Closed
refactor(ED25519/keyloader): Change to load from raw bytes.#16tinymahua wants to merge 9 commits intopyauth:mainfrom
tinymahua wants to merge 9 commits intopyauth:mainfrom
Conversation
The ED25519 key pair was previously loaded from the PEM format. In the dependency library cryptography, the EDPrivateKey can be used to export in the PEM format, but there seem to be some issues with the export of the EDPublicKey. Loading from the original byte string of the ED key pair can solve this problem and is also more convenient.
Member
|
Thank you for your interest in http-message-signatures. Could you elaborate on what issue you saw with serializing ed25519 keys in the PEM format? The following seems to work for me: The classes are also deliberately made available for subclassing. If you need to change the loading behavior, you could subclass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ED25519 key pair was previously loaded from the PEM format. In the dependency library cryptography, the EDPrivateKey can be used to export in the PEM format, but there seem to be some issues with the export of the EDPublicKey. Loading from the original byte string of the ED key pair can solve this problem and is also more convenient.